[WIP] (o1js) Native Prover with Napi - Proof
#2632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 13, 2025
This reverts commit f452808. Because we need access to the proof structure we cannot avoid the conversions.
This was referenced Nov 20, 2025
Closed
querolita
requested review from
Shigoto-dev19 and
hattyhattington17
and removed request for
a team
(o1js) Native Prover with Napi - POC - Verifier Index
Shigoto-dev19
approved these changes
Dec 9, 2025
|
|
||
|
|
||
| return { | ||
| proofToRust([, public_evals, proof]: ProofWithPublic): NapiProverProof { |
Contributor
There was a problem hiding this comment.
It appears to me that proofToRust and proofFromRust conversions handle Wasm/NapiProverProof; however, we mainly use External<NapiProofF> on the rust side so I wonder if this might introduce some errors while generating/verifying a proof 🤔
Co-authored-by: zkShigoto <[email protected]>
(`o1js`) Native Prover with Napi - Verifier Index
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mina side: MinaProtocol/mina#18109
proof-systems side: o1-labs/proof-systems#3368